This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 15/17] Language Server Protocol: add lsp::server abstract base class
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Jul 2017 12:02:13 -0400
- Subject: Re: [PATCH 15/17] Language Server Protocol: add lsp::server abstract base class
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dmalcolm at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8EE44C17982A
- References: <1500926714-56988-1-git-send-email-dmalcolm@redhat.com> <1500926714-56988-16-git-send-email-dmalcolm@redhat.com> <CAFiYyc0C2mtopPeLM5_Wp0=rNqrqWP8A_nj-3q-gUTtVSJN9zw@mail.gmail.com>
On Thu, 2017-07-27 at 09:55 +0200, Richard Biener wrote:
> On Mon, Jul 24, 2017 at 10:05 PM, David Malcolm <dmalcolm@redhat.com>
> wrote:
> > This patch adds an lsp::server abstract base class for implementing
> > servers for the Language Server Protocol:
> > https://github.com/Microsoft/language-server-protocol
> >
> > along with supporting classes mirroring those from the protocol
> > description.
> >
> > The public specification of the protocol uses CamelCase, and so
> > these
> > classes use CamelCase, to mirror the protocol definition.
> >
> > Only a small subset of the protocol is implemented, enough for
> > a proof-of-concept.
> >
> > Ideally much/all of this would be autogenerated from the
> > protocol definition.
> >
> > The patch also implements an ::lsp::jsonrpc_server subclass of
> > ::jsonrpc::server, handling the marshalling from JSON-RPC to
> > an lsp::server instance, expressing them as vfunc calls.
> >
> > gcc/ChangeLog:
> > * Makefile.in (OBJS): Add lsp.o.
> > * lsp.c: New file.
>
> New files should use .cc extension (we're using C++ now).
>
> Richard.
>
Thanks; will do for next iteration of the kit.