This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v12] add -fpatchable-function-entry=N,M option
- From: Andreas Schwab <schwab at suse dot de>
- To: Torsten Duwe <duwe at suse dot de>
- Cc: "Richard Earnshaw \(lists\)" <Richard dot Earnshaw at arm dot com>, Sandra Loosemore <sandra at codesourcery dot com>, Maxim Kuvyrkov <maxim dot kuvyrkov at gmail dot com>, Marek Polacek <polacek at redhat dot com>, Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, nd at arm dot com, Li Bin <huawei dot libin at huawei dot com>, Jiri Kosina <jkosina at suse dot cz>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Takahiro Akashi <takahiro dot akashi at linaro dot org>, Andrew Wafaa <Andrew dot Wafaa at arm dot com>
- Date: Wed, 26 Jul 2017 16:33:09 +0200
- Subject: Re: [PATCH v12] add -fpatchable-function-entry=N,M option
- Authentication-results: sourceware.org; auth=none
- References: <20170706140311.GA20710@suse.de> <d3e6d7a1-1f1c-c0b5-133a-0ab29eb5034d@arm.com> <20170707193028.GA17752@suse.de> <mvmbmo7uvuu.fsf@suse.de> <20170726142629.GG22969@suse.de>
On Jul 26 2017, Torsten Duwe <duwe@suse.de> wrote:
> On Wed, Jul 26, 2017 at 04:16:25PM +0200, Andreas Schwab wrote:
>> On Jul 07 2017, Torsten Duwe <duwe@suse.de> wrote:
>>
>> > diff --git a/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
>> > new file mode 100644
>> > index 00000000000..8514b10e820
>> > --- /dev/null
>> > +++ b/gcc/testsuite/c-c++-common/patchable_function_entry-decl.c
>> > @@ -0,0 +1,16 @@
>> > +/* { dg-do compile } */
>> > +/* { dg-options "-O2 -fpatchable-function-entry=3,1" } */
>> > +/* { dg-final { scan-assembler-times "nop" 2 } } */
>>
>> This fails on ia64.
>
> The solution is fairly obvious: on architectures where the nop is not called
> "nop" provide a custom, cpu-specific test, or document the failure.
But on ia64, a nop _is_ called nop.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."