This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000, 5/6] Backport patch to align .toc section
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, amodra at gmail dot com
- Date: Tue, 25 Jul 2017 09:53:57 -0500
- Subject: Re: [PATCH, rs6000, 5/6] Backport patch to align .toc section
- Authentication-results: sourceware.org; auth=none
- References: <14b717ac-c548-321d-e627-568f12730f02@linux.vnet.ibm.com>
Hi Bill,
On Sun, Jul 23, 2017 at 12:07:37PM -0500, Bill Schmidt wrote:
> Alan added code to have GCC align the .toc section in GCC 7, aligning to
> four bytes for 32-bit mode, and 8 bytes for 64-bit mode. This is normally
> unnecessary since alignment of the .toc has historically been handled by
> the standard linker script. However, people using non-standard toolchains
> can still run into problems, so as a courtesy this is now done by the
> compiler as well.
>
> We've recently seen this encountered using an out-of-service compiler, and
> would like to prevent any more occurrences by people finding interesting
> ways to avoid the standard toolchain. Thus I'd like to backport Alan's
> patch to GCC 5 and 6. Alan, please review as well to be sure I didn't
> miss any release-specific differences.
>
> Bootstrapped and tested on powerpc64le-linux-gnu with no regressions.
> Are these backports ok?
Sure, if Alan is happy with it, please commit.
Segher
> 2017-07-23 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> Backport from mainline r235874
> 2016-05-04 Alan Modra <amodra@gmail.com>
>
> * config/rs6000/rs6000.c (rs6000_elf_output_toc_section_asm_op):
> Align .toc.