Re: [PATCH] Do not silently continue if config.{build,host,gcc} fails

[Segher Boessenkool <segher at kernel dot crashing dot org>]

Ping?


Segher


On Mon, May 15, 2017 at 04:29:24PM +0000, Segher Boessenkool wrote:
> If config.{build,host,gcc} fails, configure currently silently
> continues.  This then makes it much harder than necessary to notice
> you made a stupid pasto in config.gcc (and where exactly).
> 
> This patch fixes it, by terminating if one of the config.* fails.
> 
> Testing in progress (on powerpc64-linux); is this okay for trunk if
> it passes?
> 
> 
> Segher
> 
> 
> 2017-05-15  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> 	* configure.ac: If any of the config.* scripts fail, exit 1.
> 	* configure: Regenerate.
> 
> ---
>  gcc/configure    | 6 +++---
>  gcc/configure.ac | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/gcc/configure b/gcc/configure
> index c823ffe..f3c7465 100755
> --- a/gcc/configure
> +++ b/gcc/configure
> @@ -11489,15 +11489,15 @@ fi
>  # --------------------------------------------------------
>  
>  # Collect build-machine-specific information.
> -. ${srcdir}/config.build
> +. ${srcdir}/config.build || exit 1
>  
>  # Collect host-machine-specific information.
> -. ${srcdir}/config.host
> +. ${srcdir}/config.host || exit 1
>  
>  target_gtfiles=
>  
>  # Collect target-machine-specific information.
> -. ${srcdir}/config.gcc
> +. ${srcdir}/config.gcc || exit 1
>  
>  extra_objs="${host_extra_objs} ${extra_objs}"
>  extra_gcc_objs="${host_extra_gcc_objs} ${extra_gcc_objs}"
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index acfe979..c24e83f 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -1442,15 +1442,15 @@ fi
>  # --------------------------------------------------------
>  
>  # Collect build-machine-specific information.
> -. ${srcdir}/config.build
> +. ${srcdir}/config.build || exit 1
>  
>  # Collect host-machine-specific information.
> -. ${srcdir}/config.host
> +. ${srcdir}/config.host || exit 1
>  
>  target_gtfiles=
>  
>  # Collect target-machine-specific information.
> -. ${srcdir}/config.gcc
> +. ${srcdir}/config.gcc || exit 1
>  
>  extra_objs="${host_extra_objs} ${extra_objs}"
>  extra_gcc_objs="${host_extra_gcc_objs} ${extra_gcc_objs}"
> -- 
> 1.9.3