This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [00/77] Add wrapper classes for machine_modes


Hi Richard,

On Thu, Jul 13, 2017 at 09:35:44AM +0100, Richard Sandiford wrote:
> This series is an update of:
> 
>     https://gcc.gnu.org/ml/gcc-patches/2016-12/msg00766.html
> 
> It adds a group of wrapper classes around machine_mode for modes that
> are known to belong to, or need to belong to, a particular mode_class.
> For example, it adds a scalar_int_mode wrapper for MODE_INT and
> MODE_PARTIAL_INT modes, a scalar_float_mode wrapper for MODE_FLOAT and
> MODE_DECIMAL_FLOAT modes, and so on.

<huge snip>

So what does it change in the interfaces we use?  I couldn't find an
update of documentation, maybe I missed it (it's a huge series :-) )
An overview of the new interfaces (and how they are used) would help.

>From what I can tell so far it makes things much harder to read.
Perhaps that is just because this is all new.

> I tested this by compiling the testsuite for:
> 
>     aarch64-linux-gnu alpha-linux-gnu arc-elf arm-linux-gnueabi
>     arm-linux-gnueabihf avr-elf bfin-elf c6x-elf cr16-elf cris-elf
>     epiphany-elf fr30-elf frv-linux-gnu ft32-elf h8300-elf
>     hppa64-hp-hpux11.23 ia64-linux-gnu i686-pc-linux-gnu
>     i686-apple-darwin iq2000-elf lm32-elf m32c-elf m32r-elf
>     m68k-linux-gnu mcore-elf microblaze-elf mips-linux-gnu
>     mipsisa64-linux-gnu mmix mn10300-elf moxie-rtems msp430-elf
>     nds32le-elf nios2-linux-gnu nvptx-none pdp11 powerpc-linux-gnuspe
>     powerpc-eabispe powerpc64-linux-gnu powerpc-ibm-aix7.0 riscv64-elf
>     rl78-elf rx-elf s390-linux-gnu s390x-linux-gnu sh-linux-gnu
>     sparc-linux-gnu sparc64-linux-gnu sparc-wrs-vxworks spu-elf
>     tilegx-elf tilepro-elf xstormy16-elf v850-elf vax-netbsdelf
>     visium-elf x86_64-darwin x86_64-linux-gnu xtensa-elf
> 
> and checking that there were no changes in assembly.  Also tested
> in the normal way on aarch64-linux-gnu, powerc64-linux-gnu and
> x86_64-linux-gnu.

Could you also test powerpc64le-linux please?  It is a primary
platform.  gcc112 is a nice fast machine.


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]