This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/6] lra-assigns.c: fix pseudo_compare_func
- From: Jeff Law <law at redhat dot com>
- To: Alexander Monakov <amonakov at ispras dot ru>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 19 Jul 2017 00:48:53 -0600
- Subject: Re: [PATCH 3/6] lra-assigns.c: fix pseudo_compare_func
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9ECBB7EBD3
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9ECBB7EBD3
- References: <20170715204749.24398-1-amonakov@ispras.ru> <20170715204749.24398-4-amonakov@ispras.ru>
On 07/15/2017 02:47 PM, Alexander Monakov wrote:
> This comparator lacks anti-commutativity and can indicate
> A < B < A if both A and B satisfy non_spilled_static_chain_regno_p.
> Proceed to following tie-breakers in that case.
>
> (it looks like the code incorrectly assumes that at most one register
> in the array will satisfy non_spilled_static_chain_regno_p)
>
> * lra-assigns.c (pseudo_compare_func): Fix comparison step based on
> non_spilled_static_chain_regno_p.
OK.
jeff