This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: backport nvptx patch to gcc-7-branch
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Thomas Schwinge <thomas at codesourcery dot com>
- Date: Tue, 18 Jul 2017 14:39:56 +0200
- Subject: Re: backport nvptx patch to gcc-7-branch
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 44759C0587D8
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 44759C0587D8
- References: <55a722a5-4452-ed93-267e-e44b1d0572ed@mentor.com> <45a641d5-1a0a-2e36-d3dc-5c02f094d3c0@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jul 18, 2017 at 02:37:38PM +0200, Tom de Vries wrote:
> I'd like to backport this nvptx patch to the gcc-7-branch.
>
> The patch doesn't trivially fit into the category of regression or
> documentation fix.
>
> Without this patch, when building an nvptx offloading compiler and running
> the libgomp testsuite for the gcc-7-branch, the GPU hangs, and I've had a
> report from a colleague who experienced system crashes because of it.
>
> However, in principle gcc is not doing anything wrong: the generated code is
> according to the ptx spec. It's just that the patch makes it less likely to
> run into a ptx JIT bug.
>
> Then again, it's an nvptx patch, neither a primary nor secondary target.
>
> I'll commit the backport some time this week, unless there are objections.
Ok, thanks.
> > 0001-Insert-diverging-jump-alap-in-nvptx_single.patch
> >
> >
> > Insert diverging jump alap in nvptx_single
> >
> > 2017-07-17 Tom de Vries <tom@codesourcery.com>
> >
> > PR target/81069
> > * config/nvptx/nvptx.c (nvptx_single): Insert diverging branch as late
> > as possible.
Jakub