This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][testsuite] Add dg-require-stack-check
- From: Jeff Law <law at redhat dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 5 Jul 2017 22:50:29 -0600
- Subject: Re: [PATCH][testsuite] Add dg-require-stack-check
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=law at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com AA5B1C058ED5
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AA5B1C058ED5
- References: <CAKdteOYW7kyu-FSnMVCLEexqkE_UA3SF7Vs511BDsM2Ddsp43A@mail.gmail.com> <6e6ddb0c-29fd-f8cc-5259-4e4d6a67b8cd@redhat.com> <CAKdteOYe2Na_5NPrgc8+5Yr-n1j=F+wPqpRNUsm7ei+jpdy6FQ@mail.gmail.com>
On 07/04/2017 02:50 AM, Christophe Lyon wrote:
> On 3 July 2017 at 17:30, Jeff Law <law@redhat.com> wrote:
>> On 07/03/2017 09:00 AM, Christophe Lyon wrote:
>>> Hi,
>>>
>>> This is a follow-up to
>>> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01791.html
>>>
>>> This patch adds dg-require-stack-check and updates the tests that use
>>> dg-options "-fstack-check" to avoid failures on configurations that to
>>> not support it.
>>>
>>> I merely copied what we currently do to check if visibility flags are
>>> supported, and cross-tested on aarch64 and arm targets with the
>>> results I expected.
>>>
>>> This means that my testing does not cover the changes I propose for
>>> i386 and gnat.
>>>
>>> Is it OK nonetheless?
>>>
>>> Thanks,
>>>
>>> Christophe
>>>
>>>
>>> stack-check-et.chlog.txt
>>>
>>>
>>> 2017-07-03 Christophe Lyon <christophe.lyon@linaro.org>
>>>
>>> * lib/target-supports-dg.exp (dg-require-stack-check): New.
>>> * lib/target-supports.exp (check_stack_check_available): New.
>>> * g++.dg/other/i386-9.C: Add dg-require-stack-check.
>>> * gcc.c-torture/compile/stack-check-1.c: Likewise.
>>> * gcc.dg/graphite/run-id-pr47653.c: Likewise.
>>> * gcc.dg/pr47443.c: Likewise.
>>> * gcc.dg/pr48134.c: Likewise.
>>> * gcc.dg/pr70017.c: Likewise.
>>> * gcc.target/aarch64/stack-checking.c: Likewise.
>>> * gcc.target/arm/stack-checking.c: Likewise.
>>> * gcc.target/i386/pr48723.c: Likewise.
>>> * gcc.target/i386/pr55672.c: Likewise.
>>> * gcc.target/i386/pr67265-2.c: Likewise.
>>> * gcc.target/i386/pr67265.c: Likewise.
>>> * gnat.dg/opt49.adb: Likewise.
>>> * gnat.dg/stack_check1.adb: Likewise.
>>> * gnat.dg/stack_check2.adb: Likewise.
>>> * gnat.dg/stack_check3.adb: Likewise.
>> ACK once you address Rainer's comments. I've got further stack-check
>> tests in the queue which I'll update once your change goes in.
>>
>> jeff
> Here is an updated version, which adds documentation for dg-require-stack-check.
>
> I also ran make-check on and x86_64 with ada enabled and checked the logs:
> the updated i386/* and gnat.dg* tests all pass, and are preceded by
> the compilation
> of the "stack_check" sample.
>
> OK?
>
> Thanks,
>
> Christophe
>
>
> stack-check-et.chlog.txt
>
>
> 2017-07-04 Christophe Lyon <christophe.lyon@linaro.org>
>
> gcc/
> * doc/sourcebuild.texi (Test Directives, Variants of
> dg-require-support): Add documentation for dg-require-stack-check.
>
> gcc/testsuite/
> * lib/target-supports-dg.exp (dg-require-stack-check): New.
> * lib/target-supports.exp (check_stack_check_available): New.
> * g++.dg/other/i386-9.C: Add dg-require-stack-check.
> * gcc.c-torture/compile/stack-check-1.c: Likewise.
> * gcc.dg/graphite/run-id-pr47653.c: Likewise.
> * gcc.dg/pr47443.c: Likewise.
> * gcc.dg/pr48134.c: Likewise.
> * gcc.dg/pr70017.c: Likewise.
> * gcc.target/aarch64/stack-checking.c: Likewise.
> * gcc.target/arm/stack-checking.c: Likewise.
> * gcc.target/i386/pr48723.c: Likewise.
> * gcc.target/i386/pr55672.c: Likewise.
> * gcc.target/i386/pr67265-2.c: Likewise.
> * gcc.target/i386/pr67265.c: Likewise.
> * gnat.dg/opt49.adb: Likewise.
> * gnat.dg/stack_check1.adb: Likewise.
> * gnat.dg/stack_check2.adb: Likewise.
> * gnat.dg/stack_check3.adb: Likewise.
OK for the trunk. Thanks for doing this!
Jeff