This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH-v3] [SPARC] Add a workaround for the LEON3FT store-store errata
- From: David Miller <davem at davemloft dot net>
- To: cederman at gaisler dot com
- Cc: ebotcazou at adacore dot com, gcc-patches at gcc dot gnu dot org, sebastian dot huber at embedded-brains dot de, daniel at gaisler dot com
- Date: Thu, 29 Jun 2017 12:05:24 -0400 (EDT)
- Subject: Re: [PATCH-v3] [SPARC] Add a workaround for the LEON3FT store-store errata
- Authentication-results: sourceware.org; auth=none
- References: <20170627085530.12596-1-cederman@gaisler.com> <9253669.0heIyC41JS@polaris> <4c5c96e9-ea63-f6f7-1066-2a907db7c393@gaisler.com>
From: Daniel Cederman <cederman@gaisler.com>
Date: Thu, 29 Jun 2017 17:15:43 +0200
>> I'm not thrilled with this, it's undocumented, the other workaround
>> don't have
>> it and I don't think that we really need it.
>
> The B2BST errata workaround requires more changes to assembler
> routines commonly used by operating systems, such as for example
> register window handling, than what the UT699 workaround needed. It
> would be nice to have a way to only enable these modification when the
> -mfix- flag is used. The alternative would be to provide a define
> directly on the compiler command line in conjunction with -mfix
> flag. But if more changes are required later on it would be good to
> have the define more closely tied to the flag to minimize the number
> of changes to Makefiles and etc.
Personally, I have never seen compiler based CPP defines as ever being
useful for tailoring OS assembler code. Ever.
In most cases you will want to support several families of CPUs and
therefore sort out the individual cpu support assembler routines
internally in the kernel sources.