This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Backports to 6 (and 7, and 5)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org, dje dot gcc at gmail dot com, wschmidt at linux dot vnet dot ibm dot com
- Date: Tue, 27 Jun 2017 19:35:55 +0200
- Subject: Re: Backports to 6 (and 7, and 5)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 10A4E61D37
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 10A4E61D37
- References: <1498516276-16423-1-git-send-email-segher@kernel.crashing.org> <alpine.LSU.2.20.1706270916250.23185@zhemvz.fhfr.qr> <20170627160237.GB16550@gate.crashing.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jun 27, 2017 at 11:02:37AM -0500, Segher Boessenkool wrote:
> On Tue, Jun 27, 2017 at 09:18:07AM +0200, Richard Biener wrote:
> > On Mon, 26 Jun 2017, Segher Boessenkool wrote:
> > > https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01853.html
> > > https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01923.html
> > > https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02048.html
> > > https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02606.html
> > > bb-reorder: Improve compgotos pass (PR71785)
> >
> > It's not clear this fixes a regression and as it is
> > a missed-optimization I'd not backport it at this point in time
> > (I understand it's in GCC 7 already).
>
> It's a regression from 3.x, and a pretty severe one, but we can live
> with it for a bit longer, it's a bit invasive for a backport.
It is just a missed-optimizations, not wrong-code, and the regression is
pretty old, so I think it doesn't hurt it if it stays fixed only in 7+.
Jakub