Re: [PATCH][Testsuite] Use user defined memmove in gcc.c-torture/execute/builtins/memops-asm-lib.c

[Renlin Li <renlin dot li at foss dot arm dot com>]

Hi Martin,

On 23/06/17 16:27, Martin Sebor wrote:
> On 06/23/2017 03:19 AM, Renlin Li wrote:
> > Hi all,
> >
> > After the change r249278. bcopy is folded into memmove. And in newlib
> > aarch64
> > memmove implementation, it will call memcpy in certain conditions.
> > The memcpy defined in memops-asm-lib.c will abort when the test is running.
> >
> > In this case, I defined a user memmove function which by pass the
> > library one.
> > So that memcpy won't be called accidentally.
> >
> > Okay to commit?
>
> Having memmove call memcpy when there is no overlap seems like
> a valid transformation.  I don't know which test specifically
> fails so the question on my mind is whether it perhaps is overly
> restrictive in assuming that this transformation must never take
> place.  Other than that, although I can't really approve patches,
> this one looks okay to me.  Thanks for getting to the bottom of
> the failure and fixing it!

Sorry I didn't mention the regressions.
It only happens with aarch64 baremetal targets because of the newlib memmove implementation.

FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -O0
FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -O1
FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -O2
FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -O3 -g
FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -Og -g
FAIL: gcc.c-torture/execute/builtins/memops-asm.c execution,  -Os

I think the purpose of the test is to check, the original function is not directly called 
from the main_test function.
Instead, those calls are redirected to "my_" version. It will abort otherwise.
I CCed Richard Sandiford as he is the original contributor of the test case.

Before r249278, bcopy has a corresponding my_bcopy function which is actually got called.

Regards,
Renlin

> Martin
>
> > gcc/testsuite/ChangeLog:
> >
> > 2017-06-22  Renlin Li  <renlin.li@arm.com>
> >         Szabolcs Nagy  <szabolcs.nagy@arm.com>
> >
> >     * gcc.c-torture/execute/builtins/memops-asm-lib.c (my_memmove): New.
> >     * gcc.c-torture/execute/builtins/memops-asm.c (memmove): Declare
> > memmove.