This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [Aarch64] Variable shift count truncation issues

From: James Greenhalgh <james dot greenhalgh at arm dot com>
To: Michael Collison <Michael dot Collison at arm dot com>
Cc: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, Christophe Lyon <christophe dot lyon at linaro dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "richard dot sandiford at linaro dot org" <richard dot sandiford at linaro dot org>, nd <nd at arm dot com>
Date: Fri, 23 Jun 2017 10:30:20 +0100
Subject: Re: [PATCH] [Aarch64] Variable shift count truncation issues
Authentication-results: sourceware.org; auth=none
Authentication-results: spf=pass (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=arm.com;
Nodisclaimer: True
References: <AM5PR0802MB2610A4E64B6EB028F6EFFB4483E50@AM5PR0802MB2610.eurprd08.prod.outlook.com> <87d1az1wi2.fsf@linaro.org> <HE1PR0802MB2377EEF9750DC4A795C79C8695F90@HE1PR0802MB2377.eurprd08.prod.outlook.com> <HE1PR0802MB2377B1CFAB6B51E15E76BD5295C00@HE1PR0802MB2377.eurprd08.prod.outlook.com> <87d1a5v084.fsf@linaro.org> <HE1PR0802MB2377EFDE0DE5CD84746BEA4B95DA0@HE1PR0802MB2377.eurprd08.prod.outlook.com> <87efudbb5j.fsf@linaro.org> <20170622101638.GA30708@arm.com> <HE1PR0802MB23776BDA9E3559268E2A9A1095D80@HE1PR0802MB2377.eurprd08.prod.outlook.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On Fri, Jun 23, 2017 at 10:27:55AM +0100, Michael Collison wrote:
> Fixed the "nitpick" issues pointed out by James. Okay for trunk?


> > I have a few comments below, which are closer to nitpicking than structural
> > issues with the patch.
> > 
> > With those fixed, this is OK to commit.

This is still OK for trunk.

Thanks,
James

> 2017-05-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 	    Michael Collison <michael.collison@arm.com>
> 
> 	PR target/70119
> 	* config/aarch64/aarch64.md (*aarch64_<optab>_reg_<mode>3_mask1):
> 	New pattern.
> 	(*aarch64_reg_<mode>3_neg_mask2): New pattern.
> 	(*aarch64_reg_<mode>3_minus_mask): New pattern.
> 	(*aarch64_<optab>_reg_di3_mask2): New pattern.
> 	* config/aarch64/aarch64.c (aarch64_rtx_costs): Account for cost
> 	of shift when the shift amount is masked with constant equal to
> 	the size of the mode.
> 	* config/aarch64/predicates.md (subreg_lowpart_operator): New
> 	predicate.
> 
> 
> 2016-05-22  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 	    Michael Collison <michael.collison@arm.com>
> 
> 	PR target/70119
> 	* gcc.target/aarch64/var_shift_mask_1.c: New test.
>

References:
- RE: [PATCH] [Aarch64] Variable shift count truncation issues
  - From: Michael Collison
- Re: [PATCH] [Aarch64] Variable shift count truncation issues
  - From: Richard Sandiford
- RE: [PATCH] [Aarch64] Variable shift count truncation issues
  - From: Michael Collison
- Re: [PATCH] [Aarch64] Variable shift count truncation issues
  - From: Richard Sandiford
- RE: [PATCH] [Aarch64] Variable shift count truncation issues
  - From: Michael Collison

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]