This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)
- From: Marek Polacek <polacek at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Sebor <msebor at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Date: Mon, 19 Jun 2017 12:01:06 +0200
- Subject: Re: C/C++ PATCH to implement -Wmultistatement-macros (PR c/80116)
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=polacek at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 40B1340F04
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 40B1340F04
- References: <20170608164936.GV3413@redhat.com> <1496942649.7551.150.camel@redhat.com> <20170613100508.GZ3413@redhat.com> <alpine.DEB.2.20.1706131529090.11434@digraph.polyomino.org.uk>
On Tue, Jun 13, 2017 at 03:29:32PM +0000, Joseph Myers wrote:
> On Tue, 13 Jun 2017, Marek Polacek wrote:
>
> > * c-parser.c (c_parser_if_body): Set the location of the
> > body of the conditional after parsing all the labels. Call
> > warn_for_multistatement_macros.
> > (c_parser_else_body): Likewise.
> > (c_parser_switch_statement): Likewise.
> > (c_parser_while_statement): Likewise.
> > (c_parser_for_statement): Likewise.
> > (c_parser_statement): Add a default argument. Save the location
> > after labels have been parsed.
> > (c_parser_c99_block_statement): Likewise.
>
> The gcc/c/ changes are OK.
Thanks.
David, do you have any more comments on the patch?
Marek