This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- Cc: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 19 Jun 2017 09:41:12 +0200
- Subject: Re: [PATCH, GCC/testsuite/ARM] Consistently check for neon in vect effective targets
- Authentication-results: sourceware.org; auth=none
- References: <e5572f24-7a4b-c92b-108d-96c270ba2e5e@foss.arm.com> <CAKdteOYuw6=p6fx22MUpU8wiFsZaHCFKuUO5ZNptO1k4t6Xf6Q@mail.gmail.com> <7281afac-431b-cf38-95d6-8c1fbc8afdce@foss.arm.com>
Hi Thomas,
On 15 June 2017 at 18:18, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> Hi,
>
> Conditions checked for ARM targets in vector-related effective targets
> are inconsistent:
>
> * sometimes arm*-*-* is checked
> * sometimes Neon is checked
> * sometimes arm_neon_ok and sometimes arm_neon is used for neon check
> * sometimes check_effective_target_* is used, sometimes is-effective-target
>
> This patch consolidate all of these check into using is-effective-target
> arm_neon and when little endian was checked, the check is kept.
>
> ChangeLog entry is as follows:
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-06-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> * lib/target-supports.exp (check_effective_target_vect_int): Replace
> current ARM check by ARM NEON's availability check.
> (check_effective_target_vect_intfloat_cvt): Likewise.
> (check_effective_target_vect_uintfloat_cvt): Likewise.
> (check_effective_target_vect_floatint_cvt): Likewise.
> (check_effective_target_vect_floatuint_cvt): Likewise.
> (check_effective_target_vect_shift): Likewise.
> (check_effective_target_whole_vector_shift): Likewise.
> (check_effective_target_vect_bswap): Likewise.
> (check_effective_target_vect_shift_char): Likewise.
> (check_effective_target_vect_long): Likewise.
> (check_effective_target_vect_float): Likewise.
> (check_effective_target_vect_perm): Likewise.
> (check_effective_target_vect_perm_byte): Likewise.
> (check_effective_target_vect_perm_short): Likewise.
> (check_effective_target_vect_widen_sum_hi_to_si_pattern): Likewise.
> (check_effective_target_vect_widen_sum_qi_to_hi): Likewise.
> (check_effective_target_vect_widen_mult_qi_to_hi): Likewise.
> (check_effective_target_vect_widen_mult_hi_to_si): Likewise.
> (check_effective_target_vect_widen_mult_qi_to_hi_pattern): Likewise.
> (check_effective_target_vect_widen_mult_hi_to_si_pattern): Likewise.
> (check_effective_target_vect_widen_shift): Likewise.
> (check_effective_target_vect_extract_even_odd): Likewise.
> (check_effective_target_vect_interleave): Likewise.
> (check_effective_target_vect_multiple_sizes): Likewise.
> (check_effective_target_vect64): Likewise.
> (check_effective_target_vect_max_reduc): Likewise.
>
> Testing: Testsuite shows no regression when targeting ARMv7-A with
> -mfpu=neon-fpv4 and -mfloat-abi=hard or when targeting Cortex-M3 with
> default FPU and float ABI (soft). Testing was done with both compare_tests
> and the updated dg-cmp-results proposed in
> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01030.html
>
> Is this ok for trunk?
>
I applied your patch on top of r249233, and noticed quite a few changes:
http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/249233-consistent_neon_check.patch/report-build-info.html
Note that "Big-Regression" cases are caused by the fact that there a
are PASS->XPASS and XFAILs disappear with your patch, and many
(3000-4000) PASS disappear.
In that intended?
Thanks,
Christophe
> Best regards,
>
> Thomas
>
> On 13/06/17 20:22, Christophe Lyon wrote:
>>
>> Hi Thomas,
>>
>> On 13 June 2017 at 11:08, Thomas Preudhomme
>> <thomas.preudhomme@foss.arm.com> wrote:
>>>
>>> Hi,
>>>
>>> Conditions checked for ARM targets in vector-related effective targets
>>> are inconsistent:
>>>
>>> * sometimes arm*-*-* is checked
>>> * sometimes Neon is checked
>>> * sometimes arm_neon_ok and sometimes arm_neon is used for neon check
>>> * sometimes check_effective_target_* is used, sometimes
>>> is-effective-target
>>>
>>> This patch consolidate all of these check into using is-effective-target
>>> arm_neon and when little endian was checked, the check is kept.
>>>
>>> ChangeLog entry is as follows:
>>>
>>> *** gcc/testsuite/ChangeLog ***
>>>
>>> 2017-06-06 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> * lib/target-supports.exp (check_effective_target_vect_int):
>>> Replace
>>> current ARM check by ARM NEON's availability check.
>>> (check_effective_target_vect_intfloat_cvt): Likewise.
>>> (check_effective_target_vect_uintfloat_cvt): Likewise.
>>> (check_effective_target_vect_floatint_cvt): Likewise.
>>> (check_effective_target_vect_floatuint_cvt): Likewise.
>>> (check_effective_target_vect_shift): Likewise.
>>> (check_effective_target_whole_vector_shift): Likewise.
>>> (check_effective_target_vect_bswap): Likewise.
>>> (check_effective_target_vect_shift_char): Likewise.
>>> (check_effective_target_vect_long): Likewise.
>>> (check_effective_target_vect_float): Likewise.
>>> (check_effective_target_vect_perm): Likewise.
>>> (check_effective_target_vect_perm_byte): Likewise.
>>> (check_effective_target_vect_perm_short): Likewise.
>>> (check_effective_target_vect_widen_sum_hi_to_si_pattern):
>>> Likewise.
>>> (check_effective_target_vect_widen_sum_qi_to_hi): Likewise.
>>> (check_effective_target_vect_widen_mult_qi_to_hi): Likewise.
>>> (check_effective_target_vect_widen_mult_hi_to_si): Likewise.
>>> (check_effective_target_vect_widen_mult_qi_to_hi_pattern):
>>> Likewise.
>>> (check_effective_target_vect_widen_mult_hi_to_si_pattern):
>>> Likewise.
>>> (check_effective_target_vect_widen_shift): Likewise.
>>> (check_effective_target_vect_extract_even_odd): Likewise.
>>> (check_effective_target_vect_interleave): Likewise.
>>> (check_effective_target_vect_multiple_sizes): Likewise.
>>> (check_effective_target_vect64): Likewise.
>>> (check_effective_target_vect_max_reduc): Likewise.
>>>
>>> Testing: Testsuite shows no regression when targeting ARMv7-A with
>>> -mfpu=neon-fpv4 and -mfloat-abi=hard or when targeting Cortex-M3 with
>>> default FPU and float ABI (soft).
>>>
>>
>> That's strange, my testing detects a syntax error:
>>
>> Executed from: gcc.dg/vect/vect.exp
>> gcc.dg/vect/slp-9.c: error executing dg-final: unbalanced close paren
>>
>> See
>> http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/249142-consistent_neon_check/report-build-info.html
>> for a full picture.
>>
>> Note that the cells with "BETTER" seem to be mostly several PASSes
>> becoming unsupported.
>>
>> Thanks,
>>
>> Christophe
>>
>>> Is this ok for trunk?
>>>
>>> Best regards,
>>>
>>> Thomas