This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] (v3) Fold vector shifts in GIMPLE
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: Will Schmidt <will_schmidt at vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>, David Edelsohn <dje dot gcc at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 16 Jun 2017 09:53:38 +0200
- Subject: Re: [PATCH, rs6000] (v3) Fold vector shifts in GIMPLE
- Authentication-results: sourceware.org; auth=none
- References: <1497383085.24125.155.camel@brimstone.rchland.ibm.com> <20170615175335.GG16550@gate.crashing.org>
On Thu, Jun 15, 2017 at 7:53 PM, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
> Hi Will,
>
> On Tue, Jun 13, 2017 at 02:44:45PM -0500, Will Schmidt wrote:
>> I sniff-tested the latest changes on Power8, with good results. Full
>> regtest running. OK for trunk?
>
> This looks good to me, if Richard is happy with it now. Some very minor
> things and it is good to go:
Yes, looks good to me.
Richard.
>> 2017-06-13 Will Schmidt <will_schmidt@vnet.ibm.com>
>>
>> * config/rs6000/rs6000.c: Add include of ssa-propagate.h for
>> update_call_from_tree().
>> (rs6000_gimple_fold_builtin): Add handling
>> for early expansion of vector shifts (sl,sr,sra,rl).
>
> Funny line break there.
>
>> + /* Flavors of vector shift right algebraic.
>> + * vec_sra{b,h,w} -> vsra{b,h,w}. */
>
> No leading * in comments please (more of those below).
>
>> + /* convert arg0 to unsigned. */
>
> Full sentences are capitalized.
>
>
> Segher