This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Cleanup cp_genericize_r
- From: Nathan Sidwell <nathan at acm dot org>
- To: Jakub Jelinek <jakub at redhat dot com>, Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 14 Jun 2017 07:20:48 -0400
- Subject: Re: [C++ PATCH] Cleanup cp_genericize_r
- Authentication-results: sourceware.org; auth=none
- References: <20170614060457.GN2099@tucnak>
On 06/14/2017 02:04 AM, Jakub Jelinek wrote:
This patch transforms this into a big switch (with 29 case labels),
so that the compiler can decide more easily how to expand it efficiently
(I think we don't have an optimization pass that would transform the above
into a switch). The patch is large, but mostly because I had to reindent
some chunks of code, so I've also attached a diff -upbd which is much
smaller and easier to read.
Yes please!
+ case FOR_STMT:
+ genericize_for_stmt (stmt_p, walk_subtrees, data);
+ break;
+ case WHILE_STMT:
I think it'd read even better with a blank line before cases not
preceded by a label statement. You're inconsistent about that.
Ok with or without changing that.
nathan
--
Nathan Sidwell