This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat targets.


Hi Christophe,

> > gcc/testsuite/
> > 2017-06-12  Tamar Christina  <tamar.christina@arm.com>
> >
> >         * gcc.target/arm/sdiv_costs_1.c: Require arm_v8_vfp_ok.
> >
> 
> I think you forgot to add a dg-add-options directive, to add -march=armv8-a
> or similar.

Weird, is it still failing? When I tested it was skipping one configuration and executing the rest.

arm_v8_vfp_ok is supposed to add -mfpu=fp-armv8. When I tried it with dg-add-options it didn't
work because it kept adding more options after the -march=armv8-a and reverting it back to armv7.

The only way I found that seemed to work was skipping the test if not supported.

In principle all I really need to know is if the target has a hardware div, but
check_effective_target_arm_divmod_simode did not seem to work.

> 
> Christophe
> 
> > Thanks,
> > Tamar
> > ________________________________________
> > From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org>
> on
> > behalf of Tamar Christina <Tamar.Christina@arm.com>
> > Sent: Monday, June 12, 2017 1:35:08 PM
> > To: GCC Patches
> > Cc: nd; Kyrylo Tkachov; Richard Earnshaw; Ramana Radhakrishnan
> > Subject: [GCC][PATCH][ARM][Committed] Disable sdiv_1 test on softfloat
> targets.
> >
> > Hi All,
> >
> > I committed this as r249122 under the GCC obvious rule.
> >
> > This fixes the failing test gcc.target/arm/sdiv_costs_1.c on soft
> > float targets by disabling it on those targets since the div calls aren't
> expanded.
> >
> > gcc/testsuite/
> > 2017-06-12  Tamar Christina  <tamar.christina@arm.com>
> >
> >         * gcc.target/arm/sdiv_costs_1.c: Disable on softfloat.
> >
> > Thanks,
> > Tamar

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]