This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] testsuite: example plugin for spellchecking comments
- From: Mike Stump <mikestump at comcast dot net>
- To: David Malcolm <dmalcolm at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 8 Jun 2017 12:47:06 -0700
- Subject: Re: [PATCH] testsuite: example plugin for spellchecking comments
- Authentication-results: sourceware.org; auth=none
- References: <CFE71610-A92F-4A9B-8294-235827E33FBD@comcast.net> <1496916425-24790-1-git-send-email-dmalcolm@redhat.com>
On Jun 8, 2017, at 3:07 AM, David Malcolm <dmalcolm@redhat.com> wrote:
>
> Given that Enchant seems a stretch as a hard dependency,
But, by using autoconf, it isn't a hard dependency. If it is there, it is built, if it isn't, it isn't. I think it should be trivial (10-20 lines) to do this.
If you want to ship this, I think it makes more sense to just do that. Build and install in the usual way, conditionalizing the build as necessary. I think the autoconf code is 10-20 lines.
We could drop this into the testsuite as a test of the infrastructure, if you want; but if you'd like to ship it, I'd rather just start it in the source tree. If you'd prefer to not ship it for now and just have it live in the testsuite, the patch is Ok. I'd like to see it shipped.