This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add missing entry for -Wduplicated-branches
- From: Marek Polacek <polacek at redhat dot com>
- To: Volker Reichelt <v dot reichelt at netcologne dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 5 Jun 2017 16:42:43 +0200
- Subject: Re: [PATCH] Add missing entry for -Wduplicated-branches
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=polacek at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A17AC8123D
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A17AC8123D
- References: <tkrat.12753442f41d636f@netcologne.de>
On Mon, Jun 05, 2017 at 02:38:11PM +0200, Volker Reichelt wrote:
> Hi,
>
> the warning option -Wduplicated-branches added by Marek in r244705
> https://gcc.gnu.org/viewcvs?rev=244705&root=gcc&view=rev
> lacks an entry in the warning list of doc/invoke.texi.
Oops.
> The patch below fixes that.
>
> OK for trunk?
> What about the GCC 7 branch?
Can't approve, but I think this is obvious, so I'd just go ahead with this.
> Regards,
> Volker
>
> 2017-06-05 Volker Reichelt <v.reichelt@netcologne.de>
>
> * doc/invoke.texi (-Wduplicated-branches): Add to warning list.
>
> Index: gcc/doc/invoke.texi
> ===================================================================
> --- gcc/doc/invoke.texi (revision 248863)
> +++ gcc/doc/invoke.texi (working copy)
> @@ -273,7 +273,8 @@
> -Wno-deprecated -Wno-deprecated-declarations -Wno-designated-init @gol
> -Wdisabled-optimization @gol
> -Wno-discarded-qualifiers -Wno-discarded-array-qualifiers @gol
> --Wno-div-by-zero -Wdouble-promotion -Wduplicated-cond @gol
> +-Wno-div-by-zero -Wdouble-promotion @gol
> +-Wduplicated-branches -Wduplicated-cond @gol
> -Wempty-body -Wenum-compare -Wno-endif-labels -Wexpansion-to-defined @gol
> -Werror -Werror=* -Wextra-semi -Wfatal-errors @gol
> -Wfloat-equal -Wformat -Wformat=2 @gol
> ===================================================================
>
Marek