This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,DWARF,v2] AIX dwarf2out label fix
- From: Jason Merrill <jason at redhat dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Jun 2017 16:16:22 -0400
- Subject: Re: [PATCH,DWARF,v2] AIX dwarf2out label fix
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnynLjij7d2Led0mhTGcK=cYEfXyRmRy6gx9CG7EX-QA7GA@mail.gmail.com> <bb98e3a4-cd62-3733-0844-4235fdd55d88@redhat.com> <CAGWvnynRE2cEdAkeqtva3G=ZhedoQSc5uzV7D8_0_J=OC_9gEQ@mail.gmail.com>
On Thu, Jun 1, 2017 at 3:27 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> On Thu, Jun 1, 2017 at 3:03 PM, Jason Merrill <jason@redhat.com> wrote:
>> On 05/18/2017 06:00 AM, David Edelsohn wrote:
>>>
>>> This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on
>>> DWARF_OFFSET_SIZE to define the string expression to append to the
>>> label to correct the offset.
>>>
>>> Because AIX Assembler inserts the section length, the section label
>>> generated by GCC points to the wrong location and must be adjusted
>>> when referenced in DW_AT_stmt_list.
>>>
>>> + char dl_section_label[MAX_ARTIFICIAL_LABEL_BYTES];
>>
>> It seems inaccurate to call this variable "label" when it's a label name
>> minus offset. Maybe dl_section_ref?
>
> Hi, Jason
>
> Thanks for taking a look at this!
>
> Any naming suggestions are appreciated -- I was trying to choose a
> short variable name. dl_section_ref is fine with me.
Let's go with that, then. OK with that change.
Jason