This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gcc::context creation


On Tue, May 16, 2017 at 5:26 PM, Nathan Sidwell <nathan@acm.org> wrote:
> This patch breaks apart the creation of the pass manager from gcc::context's
> ctor.  This will allow us to register additional dumps between the dumpfile
> manager creation and the pass manager.  As I described in
> https://gcc.gnu.org/ml/gcc-patches/2017-05/msg01164.html when I tried to do
> this for the language-specific dumps, the existing LANG_HOOKS_INIT_OPTIONS
> ran too late, and I had to create a new hook and call it from gcc::context's
> constructor to get it done before the passes were created.  That's ugly.
> Calling the hook from toplev seems better.
>
> Also, I noticed that we were passing a pointer to the
> not-yet-fully-constructed context to the pass manager, which smells funny.
>
> ok?

Ok.  Might break JIT?

Thanks,
Richard.

> nathan
> --
> Nathan Sidwell


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]