This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [i386] Recompute the frame layout less often
- From: Daniel Santos <daniel dot santos at pobox dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Uros Bizjak <ubizjak at gmail dot com>
- Date: Sun, 14 May 2017 04:16:29 -0500
- Subject: Re: [PATCH] [i386] Recompute the frame layout less often
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR0701MB216949510BB0F8FA80A60952E4E00@HE1PR0701MB2169.eurprd07.prod.outlook.com>
On 05/14/2017 02:42 AM, Bernd Edlinger wrote:
Hi,
this patch uses the new TARGET_COMPUTE_FRAME_LAYOUT hook in the i386
backend to avoid re-computing the frame layout when not really
necessary.
It simplifies the logic in ix86_compute_frame_layout by removing
the use_fast_prologue_epilogue_nregs, which is no longer necessary,
because the frame layout can no longer change spontaneously.
Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Is it OK for trunk?
Thanks
Bernd.
I think Uros is about to commit my improvements to ms to sysv abi calls,
which is a large change and will conflict with your patch. I've added
several new fields to struct ix86_frame that will need to be merged (and
moved to i386.h). I believe that my only explicit check of
crtl->stack_realign_finalized is during pro/epilogue expand, and not in
ix86_compute_frame_layout. A former incarnation of my patches needed
ix86_compute_frame_layout to be called *after* it was set, but I believe
that is no longer the case, and so shouldn't conflict, but retesting
should certainly be done.
https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01338.html
Thanks,
Daniel