This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap on arm target
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Arnaud Charlet <charlet at adacore dot com>, Tristan Gingold <gingold at adacore dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Wed, 10 May 2017 13:18:18 +0000
- Subject: Re: [PATCH] Fix bootstrap on arm target
- Authentication-results: sourceware.org; auth=none
- Authentication-results: adacore.com; dkim=none (message not signed) header.d=none;adacore.com; dmarc=none action=none header.from=hotmail.de;
- References: <AM4PR0701MB21625C8CD77FE18BAAC23DFEE4EF0@AM4PR0701MB2162.eurprd07.prod.outlook.com> <20170509131032.GA27466@adacore.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 05/09/17 15:10, Arnaud Charlet wrote:
>>
>> since a few days the bootstrap of ada fails on a native arm target.
>>
>> It is due to a -Werror warning when passing GNAT_EXCEPTION_CLASS
>> which is a string constant to exception_class_eq, but C++ forbids to cast
>> that to "char*".
>>
>> Not sure what is the smartest solution, I tried the following and it
>> seems to work for x86_64-pc-linux-gnu and arm-linux-gnueabihf.
>>
>> Is it OK for trunk?
>
> Patch looks OK to me FWIW. Tristan?
>
so, should I go ahead and commit it?
>> 2017-05-09 Bernd Edlinger <bernd.edlinger@hotmail.de>
>>
>> * raise-gcc.c (exception_class_eq): Make ec parameter const.
>>
>> --- gcc/ada/raise-gcc.c.jj 2017-04-27 12:00:42.000000000 +0200
>> +++ gcc/ada/raise-gcc.c 2017-05-09 09:45:59.557507045 +0200
>> @@ -909,7 +909,8 @@
>> /* Return true iff the exception class of EXCEPT is EC. */
>>
>> static int
>> -exception_class_eq (const _GNAT_Exception *except,
>> _Unwind_Exception_Class ec)
>> +exception_class_eq (const _GNAT_Exception *except,
>> + const _Unwind_Exception_Class ec)
>> {
>> #ifdef __ARM_EABI_UNWINDER__
>> return memcmp (except->common.exception_class, ec, 8) == 0;
>