This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/5] c++: New warning option -Wstring-plus-int
- From: Xi Ruoyao <ryxi at stu dot xidian dot edu dot cn>
- To: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Cc: ryxi at stu dot xidian dot edu dot cn
- Date: Sat, 29 Apr 2017 10:57:01 +0800
- Subject: Re: [PATCH 2/5] c++: New warning option -Wstring-plus-int
- Authentication-results: sourceware.org; auth=none
- References: <1487761271.2882.65.camel@stu.xidian.edu.cn> <403fe70c-c7f3-f9f5-e404-30ea2a1af99f@redhat.com>
On 2017-04-28 14:34 -0600, Jeff Law wrote:
> Can you use TYPE_MAIN_VARIANT (type) here rather than building a new type?
I'll check the macros.
> Formatting problems should be obvious :-)
I'll follow the GCC formatting rules.
> I think Jason probably needs to chime in on this patch. I'm not keen on
> the way we stash away the arguments into orig_argX. Perhaps he's got a
> better suggestion.
In the recent version of Clang, this warning options has been seperated
into two options -Wstring-plus-int and -Wstring-plus-char. Maybe I should
do the same.
--
Xi Ruoyao <ryxi@stu.xidian.edu.cn>
School of Aerospace Science and Technology, Xidian University