This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/8] Make gcno more precise about BBs really belonging to a line (PR gcov-profile/79891).
On 04/25/2017 09:08 AM, marxin wrote:
gcc/ChangeLog:
2017-04-26 Martin Liska <mliska@suse.cz>
PR gcov-profile/79891
* gcov.c (add_line_counts): Assign BBs to lines just if the BB
is marked by compiler as living on a line.
(get_cycles_count): Remove usage of the union.
(output_intermediate_file): Likewise.
(find_source): Fix GNU coding style.
(accumulate_line_counts): Remove old non-all block mode.
(output_lines): Remove usage of the union.
* profile.c (output_location): Include all BBs, even if
belonging to a same line (and file) as a previous BB.
@@ -2269,32 +2262,32 @@ add_line_counts (coverage_t *coverage, function_t *fn)
block->cycle.arc = NULL;
block->cycle.ident = ~0U;
+ if (!has_any_line)
+ has_any_line = true;
You know, you're allowed to set a true bool to true :)
Could you annotate the testcase with what the original problem was?
I think that'll help a future regression investigator.
otherwise ok.
nathan
--
Nathan Sidwell