This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 80121: Memory leak with derived-type intent(out) argument
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Thomas Koenig <tkoenig at netcologne dot de>
- Date: Mon, 24 Apr 2017 10:56:57 +0200
- Subject: Re: [Patch, Fortran] PR 80121: Memory leak with derived-type intent(out) argument
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qic4cpRqy_XR00yUbPWPtD4vvHB+v87+L2cURfeECYewQ@mail.gmail.com> <CAKdteOYOM=pb8+LePd14fhQvi35D-z5fAkwGRSWrhrXjn0Ww0g@mail.gmail.com>
Hi Christophe,
2017-04-24 10:25 GMT+02:00 Christophe Lyon <christophe.lyon@linaro.org>:
>>>> the patch in the attachment fixes a memory leak by auto-deallocating
>>>> the allocatable components of an allocatable intent(out) argument.
>>>>
>>>> Regtests cleanly on x86_64-linux-gnu. Ok for trunk?
>>>
>>> OK for trunk.
>>
>> thanks for the review! Committed as r247083.
>
> This patch causes an error message from DejaGnu:
> (DejaGnu) proc "cleanup-tree-dump original" does not exist.
thanks for letting me know. I didn't notice that ...
> I'm not familiar with fortran, so I'm not sure it is as obvious as
> removing cleanup-tree-dump as it is done in the other neighboring tests?
Yes, probably it should just be removed. I assume this kind of cleanup
is being done automatically now? I actually took it from this wiki
page:
https://gcc.gnu.org/wiki/TestCaseWriting
So I guess this needs to be updated as well. Will take care of both
points tonight ...
Cheers,
Janus