This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix typos in comments throughout source tree
- From: Mike Stump <mrs at mrs dot kithrup dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 3 Apr 2017 11:47:12 -0700
- Subject: Re: [PATCH] Fix typos in comments throughout source tree
- Authentication-results: sourceware.org; auth=none
- References: <20170403175316.GH4425@redhat.com>
On Apr 3, 2017, at 10:53 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>
> This fixes lots of typos throughout the tree. Can this be committed to
> trunk as obvious?
Yes, it can. However, I like it when even this patch is reviewed. I reviewed it, looks good.
You missed initialisers -> initializers.
Not sure I like datastructures, should be data structures?
figure out that poth parameters -> figure out that both parameters
> I've bootstrapped the C and C++ compilers, but not Ada, and of course
> not compiled all the target changes in gcc/config/*
>
> Is one big commit OK, or one per-ChangeLog? Or something else?
I'd just do one big commit.