This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch ping


On 03/31/2017 12:36 AM, Jakub Jelinek wrote:
Hi!

I'd like to ping two patches:

PR c++/79572
  - ubsan instrumentation of reference binding to NULL if the reference
    is folded into INTEGER_CST with REFERENCE_TYPE
    http://gcc.gnu.org/ml/gcc-patches/2017-03/msg01255.html
Just one question here -- we're working with pure trees or perhaps generic, not gimple here, right? Assuming that is true, this is OK.

If instead we are working with gimple, then consider renaming "stmt" in ubsan_maybe_instrument_reference -- when I see "stmt" I think a gimple statement, not a tree:-)

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]