This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

On 24/03/17 13:38, Rainer Orth wrote:

Hi Tom,


On 23/03/17 18:25, Mike Stump wrote:

On Mar 23, 2017, at 8:46 AM, Tom de Vries <Tom_deVries@mentor.com> wrote:

I've run the gcc testsuite for target nvptx-none and ran into "test for
excess errors" FAILs due to:
...
sorry, unimplemented: target cannot support alloca.

We'd encourage ports to support alloca.  :-)


OK for trunk for stage1?

Ok.  Ok for release branches and trunk as well, if you want.  I'd
recommend trunk, if your port is meant to work and test out nicely in gcc
7.


Committed to trunk.

seems you didn't properly test this patchset.
Sorry, indeed I just tested the non-alloca target, but forgot the alloca target. 

Thanks for cleaning up the mess.

- Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]