Re: [gomp4] backport misc OMP 4.5 changes from trunk

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Cesar!

On Wed, 15 Mar 2017 07:21:26 -0700, Cesar Philippidis <cesar@codesourcery.com> wrote:
> This patch backports Jakub's Fortran OMP 4.5 changes to gomp-4_0-branch.
> The original patch may be found here
> <https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00930.html>. I've applied
> it to gomp-4_0-branch.

Thanks!

As I had some local changes in my work tree causing a merge conflict, I
stumbled over the following part of your commit:

> --- a/gcc/gimplify.c
> +++ b/gcc/gimplify.c

> @@ -6636,9 +6596,9 @@ gimplify_scan_omp_clauses (tree *list_p, gimple_seq *pre_p,
>    ctx = new_omp_context (region_type);
>    ctx->clauses = *list_p;
>    outer_ctx = ctx->outer_context;
> -  if (code == OMP_TARGET && !(lang_GNU_Fortran () && !(region_type & ORT_ACC)))
> +  if (code == OMP_TARGET)
>      {
> -      if (!lang_GNU_Fortran () || region_type & ORT_ACC)
> +      if (!lang_GNU_Fortran ())
>  	ctx->target_map_pointers_as_0len_arrays = true;
>        ctx->target_map_scalars_firstprivate = true;
>      }

Is it intentional that you're now no longer enabling
target_map_pointers_as_0len_arrays for Fortran OpenACC regions?  If
that's not intentional, then I guess we're missing some tree-dump
scanning test cases to verify the expected behavior?


(Have not yet reviewed the changes any further.)


Grüße
 Thomas