This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Denis Khalikov <d dot khalikov at partner dot samsung dot com>, Ian Lance Taylor <iant at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 14 Mar 2017 09:27:17 +0100
- Subject: Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace
- Authentication-results: sourceware.org; auth=none
- References: <CGME20170313171637eucas1p2d70c4ed7cbd6d088c8c58dc76e1ef722@eucas1p2.samsung.com> <2d276071-3570-0a00-d046-29d5b84f2b7f@partner.samsung.com>
On Mon, Mar 13, 2017 at 6:16 PM, Denis Khalikov
<d.khalikov@partner.samsung.com> wrote:
> Hello everyone, i have a patch for this issue.
Great!
> List of implemented functionality:
>
> 1.Reading .gnu_debuglink section from ELF file:
> a. Reading name of debug info file.
> b. Verifying crc32 sum.
>
> 2. Searching for separate debug info file from paths:
> a. /usr/lib/debug/path/to/executable
> b. /path/to/executable
> c. /path/to/executable/.debug
>
> Assumed that debug info file generated by objcopy from binutils.
>
> objcopy --only-keep-debug foo foo.debug
> strip -g foo
> objcopy --add-gnu-debuglink=foo.debug foo
Skimming over the patch I noticed you duplicate libiberties xcrc32
functionality.
Also the additions to posix.c probably belong to dwarf.c and elf.c (the feature
is dwarf + elf specific but proper abstraction / #ifdefing should
ensure compiling
also succeeds for non-dwarf / non-elf platforms).
Leaving actual review to the maintainer (CCed).
Thanks,
Richard.