This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcov: Mark BBs that do not correspond to a line in source code (PR gcov-profile/79891).
- From: Richard Biener <rguenther at suse dot de>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Nathan Sidwell <nathan at acm dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 13 Mar 2017 13:52:47 +0100 (CET)
- Subject: Re: [PATCH] gcov: Mark BBs that do not correspond to a line in source code (PR gcov-profile/79891).
- Authentication-results: sourceware.org; auth=none
- References: <113a3fb2-817c-ff7c-e57a-d5ee1656d4b9@suse.cz>
On Fri, 10 Mar 2017, Martin Liška wrote:
> Hello.
>
> As briefly discussed in the PR, there are BB that do not correspond to a real
> line in source
> code. profile.c emits locations for all BBs that have a gimple statement
> belonging to a line.
> I hope these should be marked in gcov utility and not added in --all-block
> mode to counts of lines.
>
> Patch survives make check RUNTESTFLAGS="gcov.exp".
>
> Thanks for review and feedback.
Humm, the patch doesn't seem to change the BBs associated with a line
but rather somehow changes how we compute counts (the patch lacks a
description of how you arrived at it). I expected the line-to-BB
assignment process to be changed (whereever that is...).
Richard.
> Martin
>
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)