This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Decrease compile time memory with heavy find_base_{value,term} on i?86/x86_64 (PR rtl-optimization/63191)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 10 Mar 2017 19:57:39 +0100
- Subject: Re: [PATCH] Decrease compile time memory with heavy find_base_{value,term} on i?86/x86_64 (PR rtl-optimization/63191)
- Authentication-results: sourceware.org; auth=none
- References: <20170310175329.GX22703@tucnak> <d078d123-e5ec-eb1b-8da8-cc43f17182d4@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Mar 10, 2017 at 07:52:37PM +0100, Bernd Schmidt wrote:
> On 03/10/2017 06:53 PM, Jakub Jelinek wrote:
> > +
> > +template <bool base_term_p>
> > +static inline rtx
> > +ix86_delegitimize_address_tmpl (rtx x)
> > {
>
> Why is this a template and not a function arg?
That was just an attempt to ensure that the compiler actually
either inlines it, or doesn't share code between the two versions, so the
base_term_p argument isn't checked at runtime.
But, as I said, I have no problem changing that, i.e.
remove the template line, s/_tmpl/_1/, add , bool base_term_p
and tweak both callers.
Jakub