This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/5] testsuite: attr-alloc_size-11.c (PR79356)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: gcc-patches at gcc dot gnu dot org, dje dot gcc at gmail dot com, Martin Sebor <msebor at gmail dot com>
- Date: Fri, 10 Mar 2017 13:57:31 +0100
- Subject: Re: [PATCH 1/5] testsuite: attr-alloc_size-11.c (PR79356)
- Authentication-results: sourceware.org; auth=none
- References: <ffb1b7f7e4414214d2835fb534dcc414445f5e03.1486654190.git.segher@kernel.crashing.org> <yddlgtefh5k.fsf@CeBiTec.Uni-Bielefeld.DE> <20170210144921.GJ21840@gate.crashing.org>
Hi Segher,
> On Fri, Feb 10, 2017 at 11:56:39AM +0100, Rainer Orth wrote:
>> Segher Boessenkool <segher@kernel.crashing.org> writes:
>>
>> > As stated in the PR, this test now passes on aarch64, ia64, powerpc,
>> > and s390x. This patch disables the xfails for those targets.
>>
>> As I'd mentioned in PR tree-optimization/78775, the test XPASSes on
>> SPARC, too.
>>
>> > Tested on powerpc64-linux {-m32,-m64}. Is this okay for trunk?
>> [...]
>> > 2017-02-09 Segher Boessenkool <segher@kernel.crashing.org>
>> >
>> > gcc/testsuite/
>> > PR testsuite/79356
>> > * gcc.dg/attr-alloc_size-11.c: Don't xfail on aarch64, ia64, powerpc,
>> > or s390x.
>>
>> TBH, I'd strongly prefer to have a proper analysis instead of just
>> un-xfail-ing the test on an ever growing apparently random list of
>> targets.
>
> Yeah, I agree. I thought it was just another test that stopped failing,
> but it seems to fail in two ways now, making the testcase succeed?
> Lovely. Please consider this patch withdrawn.
I just noticed that nothing has happened at all in a month, so anything
is better than the tests XPASSing on a number of targets.
So the patch is ok for mainline with sparc*-*-* added to the target
lists and a reference to PR testsuite/79356 in the comment.
I'd still be very grateful if Martin could have a look what's really
going on here, though.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University