This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/7] Remove trailing period from various diagnostic messages (PR translation/79923)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Kyrylo Tkachov <kyrylo dot tkachov at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, roland dot illig at gmx dot de, Joseph Myers <joseph at codesourcery dot com>
- Date: Fri, 10 Mar 2017 07:24:15 +0100
- Subject: Re: [PATCH 3/7] Remove trailing period from various diagnostic messages (PR translation/79923)
- Authentication-results: sourceware.org; auth=none
- References: <1489081529-22256-1-git-send-email-dmalcolm@redhat.com> <1489081529-22256-4-git-send-email-dmalcolm@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Mar 09, 2017 at 12:45:25PM -0500, David Malcolm wrote:
> gcc/ChangeLog:
> PR translation/79923
> * auto-profile.c (get_combined_location): Convert leading
> character of diagnostics to lower case and remove trailing period.
> (read_profile): Likewise for various diagnostics.
> * config/arm/arm-builtins.c (arm_expand_builtin): Remove trailing
> period from various diagnostics.
> * config/arm/arm.c (arm_option_override): Likewise.
> * config/msp430/msp430.c (msp430_expand_delay_cycles): Likewise.
> (msp430_expand_delay_cycles): Likewise.
Mostly ok, but for
> --- a/gcc/config/arm/arm-builtins.c
> +++ b/gcc/config/arm/arm-builtins.c
> @@ -2990,60 +2990,60 @@ arm_expand_builtin (tree exp,
> && (imm < 0 || imm > 32))
> {
> if (fcode == ARM_BUILTIN_WRORHI)
> - error ("the range of count should be in 0 to 32. please check the intrinsic _mm_rori_pi16 in code.");
> + error ("the range of count should be in 0 to 32. please check the intrinsic _mm_rori_pi16 in code");
I wonder if this shouldn't use a semicolon space in the middle
instead of dot space space (many times in the same file).
Also, for the benefit of translators, this might be better done as
error ("the range of count should be in 0 to 32; please check the intrinsic %s in code",
"_mm_rori_pi16");
so that there are fewer of these messages.
Adding some ARM folks on this.
Perhaps commit everything except arm-builtins.c separately and deal with
this part with the ARM folks?
Jakub