Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

[Andre Vehreschild <vehre at gmx dot de>]

Hi Christophe,

you are right, that error message does not help a bit. Can you manually compile
and execute the testcase? Does it print "ERROR STOP: This statement should not
be reached."? 

If not what does

fail_image_2 && echo "yes" || echo "no" 

print? It should be "yes"

- Andre

On Wed, 8 Mar 2017 23:58:10 +0100
Christophe Lyon <christophe.lyon@linaro.org> wrote:

> Hi,
> 
> On 5 March 2017 at 12:41, Andre Vehreschild <vehre@gmx.de> wrote:
> > Hi Jerry,
> >
> > thanks for seconding my read of the standard and reviewing so quickly.
> > Committed as r245900.
> >  
> 
> I've noticed that the new test:
> gfortran.dg/coarray/fail_image_2.f08 -fcoarray=single  -O2  -latomic
> execution test
> fails on arm and aarch64.
> I'm using qemu if it matters, and my gfortran.log has:
> spawn /XXX/qemu-wrapper.sh ./fail_image_2.exe
> FAIL: gfortran.dg/coarray/fail_image_2.f08 -fcoarray=single  -O2
> -latomic execution test
> 
> that is, no obvious error message :-(
> 
> Am I the only one seeing this?
> 
> Thanks,
> 
> Christophe
> 
> > Regards,
> >         Andre
> >
> > On Sat, 4 Mar 2017 15:06:25 -0800
> > Jerry DeLisle <jvdelisle@charter.net> wrote:
> >  
> >> On 03/04/2017 09:58 AM, Andre Vehreschild wrote:  
> >> > Hi all,
> >> >
> >> > attached patch polishes the one begun by Alessandro. It adds
> >> > documentation and fixes the style issues. Furthermore did I try to
> >> > interpret the standard according to the FAIL IMAGE statement. IMHO
> >> > should it just quit the executable without any error code. The
> >> > caf_single library emits "FAIL IMAGE" to stderr, while in coarray=single
> >> > mode it just quits. What do you think?
> >> >
> >> > Bootstraps and regtests ok on x86_64-linux/f25. Ok for trunk? (May be
> >> > later).
> >> >
> >> > Gruß,
> >> >     Andre
> >> >  
> >>
> >> From my read:
> >>
> >> "A failed image is usually associated with a hardware failure of the
> >> processor, memory system, or interconnection network"
> >>
> >> Since the FAIL IMAGE statement is intended to simulate such failure, I
> >> agree with your interpretation as well, it just stops execution.
> >>
> >> Yes OK for trunk now.
> >>
> >> Jerry  
> >
> >
> > --
> > Andre Vehreschild * Email: vehre ad gmx dot de  


-- 
Andre Vehreschild * Email: vehre ad gmx dot de