This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix GC PCH bug in dwarf2out.c (PR c++/79821)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jason Merrill <jason at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 7 Mar 2017 10:09:01 +0100
- Subject: Re: [PATCH] Fix GC PCH bug in dwarf2out.c (PR c++/79821)
- Authentication-results: sourceware.org; auth=none
- References: <20170306205605.GF22703@tucnak> <CAFiYyc1Ufcdmy5epX7Jr3p4riUZVejrOtyATHhsaHZgX0V5B8A@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Mar 07, 2017 at 09:55:19AM +0100, Richard Biener wrote:
> > --- gcc/dwarf2out.h.jj 2017-01-01 12:45:37.000000000 +0100
> > +++ gcc/dwarf2out.h 2017-03-06 12:13:48.809589411 +0100
> > @@ -163,7 +163,7 @@ enum dw_val_class
> > /* Describe a floating point constant value, or a vector constant value. */
> >
> > struct GTY(()) dw_vec_const {
> > - unsigned char * GTY((atomic)) array;
> > + void * GTY((atomic)) array;
>
> Please add a comment here why this is void *. I wonder if we can't
I've already committed the patch, but will add some comment.
> tell gengtype
> how to compute the length though via some GTY attribute?
Maybe. The documentation mentions that length attribute doesn't
apply to GC allocations that don't contain pointers, maybe we could change
that. But my gengtype knowledge is very limited.
Jakub