Re: [PATCH,testsuite] Skip gcc.dg/lto/pr60449_0.c for mips*-*-elf* targets.

[Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>]

Hi Toma,

>> that's not what I suggested (or at least meant to suggest): having
>> gettimeofday as an effective-target keyword (like setrlimit, mmap, and
>> others) is the way to go, just your previous implementation of
>> check_effective_target_gettimeofday was problematic/unreliable.
>> 
>> If you go this route, there's no need to modify target-supports-dg.exp
>> at all.
>
> I see now. The dg-require-* directives are the predecessors to the
> dg-require-effective-target directives.

right: the latter requires less setup to implement.

> I've changed it to be a dg-require-effective-target for gettimeofday instead.
> Tested it and it works just as well as before.
>
>> Besides: I forget to mention that new effective-target keywords need to
>> be documented in sourcebuild.texi.
>
> Done. Thanks for pointing this out.
>
> There were 2 existing ways of describing this sort of effective-target; I chose
> the more succinct one.

Seems fine: I could find no difference between the two sets, just
another random difference.

> gcc/
> 	* doc/sourcebuild.texi (Effective-Target Keywords, Environment
> 	attributes): Document gettimeofday.
>
> gcc/testsuite/
>
> 	* gcc.dg/lto/pr60449_0.c: Add dg-require-effective-target for
> 	gettimeofday. Remove dg-skip-if for AVR.

Two spaces after period.

> 	* lib/target-supports.exp (check_effective_target_gettimeofday): New.

Better say "New proc." or something like this.

Ok with those nits fixed.

Thanks for your patience.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University