This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Some more translation related tweaks
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Volker Reichelt <v dot reichelt at netcologne dot de>, gcc-patches at gcc dot gnu dot org, Marek Polacek <polacek at redhat dot com>
- Date: Wed, 1 Mar 2017 12:14:23 +0100
- Subject: Re: [PATCH] Some more translation related tweaks
- Authentication-results: sourceware.org; auth=none
- References: <tkrat.a7532927a533bdd5@netcologne.de> <20170226123555.GW1849@tucnak> <tkrat.531701baee17c0a8@netcologne.de> <20170227102744.GZ1849@tucnak> <alpine.DEB.2.20.1702271245580.2646@digraph.polyomino.org.uk> <20170227173324.GC1849@tucnak> <36ea892d-a12e-f61e-18cd-8e7ca00c8629@mentor.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Mar 01, 2017 at 11:20:37AM +0100, Tom de Vries wrote:
> > 2017-02-27 Jakub Jelinek <jakub@redhat.com>
> >
> > * config/i386/i386.c (ix86_option_override_internal): Use
> > cond ? G_("...") : G_("...") instead of just cond ? "..." : "...".
> > * config/nvptx/nvptx.c (nvptx_goacc_validate_dims): Likewise.
>
> > --- gcc/config/nvptx/nvptx.c.jj 2017-02-21 15:36:03.000000000 +0100
> > +++ gcc/config/nvptx/nvptx.c 2017-02-27 15:48:20.031688240 +0100
> > @@ -4542,8 +4542,8 @@ nvptx_goacc_validate_dims (tree decl, in
> > if (fn_level < 0 && dims[GOMP_DIM_VECTOR] >= 0)
> > warning_at (decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION, 0,
> > dims[GOMP_DIM_VECTOR]
> > - ? "using vector_length (%d), ignoring %d"
> > - : "using vector_length (%d), ignoring runtime setting",
> > + ? G_("using vector_length (%d), ignoring %d")
> > + : G_("using vector_length (%d), ignoring runtime setting"),
> > PTX_VECTOR_LENGTH, dims[GOMP_DIM_VECTOR]);
> > dims[GOMP_DIM_VECTOR] = PTX_VECTOR_LENGTH;
> > changed = true;
>
> This breaks the nvptx build:
> ...
> src/gcc-mainline/gcc/config/nvptx/nvptx.c: In function 'bool
> nvptx_goacc_validate_dims(tree, int*, int)':
> src/gcc-mainline/gcc/config/nvptx/nvptx.c:4545:51: error: 'G_' was not
> declared in this scope
> ...
Oops, sorry, I've fixed it in i386.c and two other files, but missed
nvptx.c. Fixed thusly, committed to trunk:
2017-03-01 Jakub Jelinek <jakub@redhat.com>
* config/nvptx/nvptx.c: Include intl.h.
--- gcc/config/nvptx/nvptx.c.jj 2017-02-28 16:24:05.000000000 +0100
+++ gcc/config/nvptx/nvptx.c 2017-03-01 11:24:04.178802355 +0100
@@ -69,6 +69,7 @@
#include "tree-phinodes.h"
#include "cfgloop.h"
#include "fold-const.h"
+#include "intl.h"
/* This file should be included last. */
#include "target-def.h"
Jakub