Re: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).

[Jeff Law <law at redhat dot com>]

On 01/30/2017 06:32 AM, Martin Liška wrote:
> On 01/30/2017 12:27 PM, Martin Liška wrote:
> > Hi.
> >
> > Following patch simply fixes issues reported by -Wmaybe-unitialized. That enables PGO bootstrap
> > on a s390x machine.
> >
> > Ready to be installed?
> > Martin
> There's second version that adds one more hunk for s390 target.
>
> Martin
>
>
> 0001-Fix-PGO-bootstrap-on-x390x-PR-bootstrap-78985-v2.patch
>
>
> From 598d0a59b91070211b09056195bc0f971bc57ae1 Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Mon, 30 Jan 2017 11:09:29 +0100
> Subject: [PATCH] Fix PGO bootstrap on x390x (PR bootstrap/78985).
>
> gcc/ChangeLog:
>
> 2017-01-30  Martin Liska  <mliska@suse.cz>
>
> 	PR bootstrap/78985
> 	* config/s390/s390.c (s390_gimplify_va_arg): Initialize local
> 	variable to NULL.
> 	(print_operand_address): Initialize a struct to zero.
Presumably the issue with print_operand_address is that there are paths 
where s390_decompose_address can return without initializing AD/OUT. 
But AFAICT those are invalid addresses that presumably shouldn't be 
showing up in print_operand_address.

Can you add an assert in print_operand_address to ensure decomposition 
never returns false?

OK with that addition.

jeff