This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] S/390: PR target/79240: Fix assertion in s390_extzv_shift_ok.

On 01/26/2017 09:42 PM, Dominik Vogt wrote:
> On Thu, Jan 26, 2017 at 05:45:18PM +0100, Jakub Jelinek wrote:
>> On Thu, Jan 26, 2017 at 05:43:13PM +0100, Dominik Vogt wrote:
>>>> If the predicates are supposed to ensure it, then I think the assert is
>>>> fine.
>>>
>>> Is it guaranteed that the predicate conditions are evaluated
>>> before executing the conditions?
>>
>> Yes.  You can see it in insn-recog.c...
> 
> Updated patch attached.
> 
> changes:
> 
>   * Don't remove assertion.
>   * Use simplified test case.
> 
> Bootstrapped and regression tested on a zEC12 with s390x biarch
> and s390.

Applied. Thanks!

-Andreas-
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]