This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] restore pedantic warning on flexible array members (c++/71290)

From: Martin Sebor <msebor at gmail dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Jason Merrill <jason at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
Date: Wed, 25 Jan 2017 17:02:59 -0700
Subject: Re: [PATCH] restore pedantic warning on flexible array members (c++/71290)
Authentication-results: sourceware.org; auth=none
References: <e9f12189-a4a6-6885-97c5-2d03ab74454f@gmail.com> <20170125235358.GV1867@tucnak>

On 01/25/2017 04:53 PM, Jakub Jelinek wrote:

On Wed, Jan 25, 2017 at 10:02:23AM -0700, Martin Sebor wrote:

--- gcc/cp/decl.c	(revision 244844)
+++ gcc/cp/decl.c	(working copy)
@@ -11798,6 +11798,17 @@ grokdeclarator (const cp_declarator *declarator,
 	      }
 	    else
 	      {
+		/* Array is a flexible member.  */
+		if (in_system_header_at (input_location))
+		  /* Do not warn flexible them in system headers because glibc
+		     uses them.  */;


The comment is weird.  Did you mean warn about them, or warn about
flexible array members or something similar?


It sure is.  I must have mangled it while copying the whole block
from the 5 branch.  I just fixed it.  Thanks for pointing it out!

Martin

References:
- [PATCH] restore pedantic warning on flexible array members (c++/71290)
  - From: Martin Sebor
- Re: [PATCH] restore pedantic warning on flexible array members (c++/71290)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]