This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] BRIG frontend: request for a global review
- From: Martin Jambor <mjambor at suse dot cz>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Pekka Jääskeläinen <pekka at parmance dot com>
- Date: Tue, 24 Jan 2017 13:52:10 +0100
- Subject: Re: [PATCH] BRIG frontend: request for a global review
- Authentication-results: sourceware.org; auth=none
- References: <CAFiYyc10E20yQiTORts82HdbB1FyuwKbLvqwnKnSZuTOXe8r1Q@mail.gmail.com> <CAJk11WAKHRzpuLx33qa_JBgGfbZOaOpg=wPS3H2rvAOaAUVy6A@mail.gmail.com> <CAFiYyc3Fjtca3gBsoOD_z8987=RHTMcWrQVMNWKvXZmT1xu_wA@mail.gmail.com> <20170116090746.GM1867@tucnak> <CAJk11WBNMcsLKkzX+GbovsDHq7mDQ0Ehxi_dBVcn9FjUCGY9eg@mail.gmail.com> <CAFiYyc2czhyGBqH5cRLX8otgGkDuJin_-bKsUq9vWaX003mNag@mail.gmail.com> <CAJk11WBpEyWmnSA9Nk3N48gnqwEecNYnNixeaLBX9Az4Hj=AAw@mail.gmail.com> <CAFiYyc1coXT531VGZ7R=2T8NjcVSGGK2Q4w6fmD5Xbpy-B=brA@mail.gmail.com> <20170123120240.h6kannl7ygryurbj@virgil.suse.cz> <CAFiYyc3Erp84wu=GR5VCZ4PLVQN3DY48id4+PubmhL-13PPwFw@mail.gmail.com>
Hi,
On Mon, Jan 23, 2017 at 02:11:37PM +0100, Richard Biener wrote:
> On Mon, Jan 23, 2017 at 1:02 PM, Martin Jambor <mjambor@suse.cz> wrote:
> > Hi,
> >
> >
> > On Mon, Jan 23, 2017 at 12:56:13PM +0100, Richard Biener wrote:
> >> On Fri, Jan 20, 2017 at 6:25 PM, Pekka Jääskeläinen <pekka@parmance.com> wrote:
> >> > Hi Richard,
> >> >
> >> > On Fri, Jan 20, 2017 at 10:26 AM, Richard Biener
> >> > <richard.guenther@gmail.com> wrote:
> >> >> So the #ifdef ENABLE_BRIG_FE shouldn't be needed anymore (nor the
> >> >> configury for it).
> >> >>
> >> >> Otherwise this looks ok to me then.
> >> >
> >> > Attached is a patch set with that unnecessary ENABLE_BRIG_FE macro
> >> > removed. It has also been refreshed to the latest trunk.
> >>
> >> Are you set up to commit these to trunk yourself or do you need help here?
> >>
> >
> > Pekka is still in the process of requesting an account at gcc.gnu.org.
> > We agreed that I would commit the patches.
> >
> > Over Saturday and today morning, I have bootstrappet and tested them
> > in various configurations (although mostly on x86_64 and only a little
> > bit on aarch64) and (together with a "svn mv libgomp/plugin/hsa.h
> > include/") I have not found any issue so far.
> >
> > I suppose I should go ahead (in any case, if there is any fallout,
> > reach out to me too, at least until Pekka gets his account).
>
> Yes, sounds good to me.
>
It took me more time because I got distracted by PR 79198 and did not
want to commit another huge thing while bootstrap was still broken for
so many people with my previous patch. Nevertheless, I have just
committed the BRIG FE as revision 244867.
I tried to be careful (as well as quick to avoid conflicts) so I hope
there are no issues. However if there are some, throw complaints my
way at least unless Pekka gets an account at gcc.gnu.org.
Thanks,
Martin