This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Tamar Christina <Tamar dot Christina at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "rguenther at suse dot de" <rguenther at suse dot de>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>, nd <nd at arm dot com>
- Date: Wed, 18 Jan 2017 16:45:46 +0000
- Subject: Re: [PATCH][GCC][PATCHv3] Improve fpclassify w.r.t IEEE like numbers in GIMPLE.
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR0801MB2027D1CA7B116B16DD1E5641FFBB0@HE1PR0801MB2027.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1611112157270.32183@digraph.polyomino.org.uk> <VI1PR0801MB2031689EAA3643B992C12E0AFFB60@VI1PR0801MB2031.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1611241821520.21096@digraph.polyomino.org.uk> <VI1PR0801MB203191C5CA00160F3DAC7E40FF890@VI1PR0801MB2031.eurprd08.prod.outlook.com> <bad2845d-1944-d792-d4d1-91eac63eb73c@redhat.com> <VI1PR0801MB20311CC45C387326291E49F1FF9D0@VI1PR0801MB2031.eurprd08.prod.outlook.com> <alpine.DEB.2.20.1612151858040.2106@digraph.polyomino.org.uk> <VI1PR0801MB20313CD2538258D3AAA60F5DFF910@VI1PR0801MB2031.eurprd08.prod.outlook.com> <72535306-7d9c-bc2d-b7a3-06360633cfef@redhat.com>
Also, I don't think the call to perform_ibm_extended_fixups in
is_subnormal is correct. Subnormal for IBM long double is *not* the same
as subnormal double high part. Likewise it's incorrect in is_normal as
well.
Generally, I don't see tests added that these new functions are correct
for float, double and long double, which would detect such issues if run
for a target with IBM long double.
--
Joseph S. Myers
joseph@codesourcery.com