Re: [PATCH] PR 78534 Change character length from int to size_t

[Janne Blomqvist <blomqvist dot janne at gmail dot com>]

On Sat, Jan 14, 2017 at 1:13 AM, Jerry DeLisle <jvdelisle@charter.net> wrote:
> On 01/13/2017 11:46 AM, David Edelsohn wrote:
>> On Fri, Jan 13, 2017 at 12:09 PM, Janne Blomqvist
>> <blomqvist.janne@gmail.com> wrote:
>>> On Thu, Jan 12, 2017 at 10:46 AM, FX <fxcoudert@gmail.com> wrote:
>>>>> I was finally able to get a 32-bit i686 compiler going (my attempts to
>>>>> do this on a x86_64-pc-linux-gnu host failed, in the end I resorted to
>>>>> running 32-bit builds/tests on a i686 container). At least on i686,
>>>>> the patch below on top of the big charlen->size_t patch fixes the
>>>>> failures
>>>>
>>>> Patch approved. The old code used gfc_extract_int, which bails out if a non-constant expression is passed, so this is the right thing to do.
>>>>
>>>> FX
>>>
>>> Committed as r244448.
>>>
>>> David, can you verify that it works alright on ppc?
>>
>> Unfortunately, no.  This patch broke bootstrap again with the same
>> failure as earlier.
>>
>> - David
>>
>
> Janne, can you access gcc112 on the compile farm? If not, I can, maybe I can
> test the patch.
>
> Jerry

No, I don't have such access. I'd appreciate it very much if you'd
have a go at it.  Attached is the r244448 patch combined with the
patch to fix the sanitizer bugs found by Dominique.

-- 
Janne Blomqvist

Attachment: 0001-PR-78534-Change-character-length-from-int-to-size_t.patch.gz
Description: GNU Zip compressed data