This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR 78534 Change character length from int to size_t
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: FX <fxcoudert at gmail dot com>, Dominique d'Humières <dominiq at lps dot ens dot fr>, GCC-Fortran-ML <fortran at gcc dot gnu dot org>, GCC-Patches-ML <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 13 Jan 2017 14:46:37 -0500
- Subject: Re: [PATCH] PR 78534 Change character length from int to size_t
- Authentication-results: sourceware.org; auth=none
- References: <60948DB4-4A24-4836-85B4-66F422215080@lps.ens.fr> <CAO9iq9HXdJb=PDiJzNZEuh4MAi-qs=VKB5d18iLwsEFUb6X3ow@mail.gmail.com> <1CFEDD0B-618B-4D73-A46C-61C5354FF6D2@gmail.com> <CAO9iq9F8o=hA-VcEOGPXxTMsLFtRV7_kb6a9S46s-ThBMaYTpA@mail.gmail.com>
On Fri, Jan 13, 2017 at 12:09 PM, Janne Blomqvist
<blomqvist.janne@gmail.com> wrote:
> On Thu, Jan 12, 2017 at 10:46 AM, FX <fxcoudert@gmail.com> wrote:
>>> I was finally able to get a 32-bit i686 compiler going (my attempts to
>>> do this on a x86_64-pc-linux-gnu host failed, in the end I resorted to
>>> running 32-bit builds/tests on a i686 container). At least on i686,
>>> the patch below on top of the big charlen->size_t patch fixes the
>>> failures
>>
>> Patch approved. The old code used gfc_extract_int, which bails out if a non-constant expression is passed, so this is the right thing to do.
>>
>> FX
>
> Committed as r244448.
>
> David, can you verify that it works alright on ppc?
Unfortunately, no. This patch broke bootstrap again with the same
failure as earlier.
- David