This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Avoid PR72749 by not using unspecs

From: Jeff Law <law at redhat dot com>
To: Alan Modra <amodra at gmail dot com>, gcc-patches at gcc dot gnu dot org
Cc: Segher Boessenkool <segher at kernel dot crashing dot org>, Uros Bizjak <ubizjak at gmail dot com>
Date: Fri, 13 Jan 2017 10:17:31 -0700
Subject: Re: Avoid PR72749 by not using unspecs
Authentication-results: sourceware.org; auth=none
References: <20170113115058.GU32333@bubble.grove.modra.org>

On 01/13/2017 04:50 AM, Alan Modra wrote:

Rather than using unspecs in doloop insns to stop combine creating
these insns, use legitimate_combined_insn.

I'm not sure why the original patch implementing
legitimate_combined_insn did not store the result of recog to the insn
but it seems good to me, and would allow the recog call in
ix86_legitimate_combined_insn to be omitted.  (I tested that too, not
shown here.)

Bootstrapped and regression tested powerpc64le-linux, powerpc64-linux,
x86_64-linux.  OK for mainline?

	PR target/72749
	* combine.c (recog_for_combine_1): Set INSN_CODE before calling
	target legitimate_combined_insn.
	* config/rs6000/rs6000.c (TARGET_LEGITIMATE_COMBINED_INSN): Define.
	(rs6000_legitimate_combined_insn): New function.
	* config/rs6000/rs6000.md (UNSPEC_DOLOOP): Delete, and remove
	all uses.
	(ctr<mode>_internal3): Rename from *ctr<mode>_internal5.
	(ctr<mode>_internal4): Rename from *ctr<mode>_internal6.
	(ctr<mode>_internal1, ctr<mode>_internal2): Remove '*' from name.

OK on the combine.c changes.  ppc maintainers own the rest.

jeff

References:
- Avoid PR72749 by not using unspecs
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]