This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix direction of polymorphic call predictor
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 6 Jan 2017 17:14:45 +0100
- Subject: Re: Fix direction of polymorphic call predictor
- Authentication-results: sourceware.org; auth=none
- References: <20170106161151.GA21169@kam.mff.cuni.cz>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jan 06, 2017 at 05:11:51PM +0100, Jan Hubicka wrote:
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 244166)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,10 @@
> +2017-01-01 Jan Hubicka <hubicka@ucw.cz>
> +
> + PR middle-end/77484
> + * predict.def (PRED_POLYMORPHIC_CALL): Set to 58
Missing . at the end. More importantly, you say 58 here, while
> --- predict.def (revision 244166)
> +++ predict.def (working copy)
> @@ -122,7 +122,7 @@ DEF_PREDICTOR (PRED_CALL, "call", HITRAT
> less reliable for indirect calls and polymorphic calls. For spec2k6
> the predictio nis slightly in the direction of taking the call. */
> DEF_PREDICTOR (PRED_INDIR_CALL, "indirect call", HITRATE (51), 0)
> -DEF_PREDICTOR (PRED_POLYMORPHIC_CALL, "polymorphic call", HITRATE (58), 0)
> +DEF_PREDICTOR (PRED_POLYMORPHIC_CALL, "polymorphic call", HITRATE (59), 0)
>
> /* Recursive calls are usually not taken or the function will recurse
> indefinitely. */
you've actually changed it from 58 to 59. So is the predict.def change
intent and ChangeLog just stale, something else?
Jakub