This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran, patch] Remove unused elements in array argument to set_options
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: FX <fxcoudert at gmail dot com>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 19 Dec 2016 14:15:31 -0800
- Subject: Re: [fortran, patch] Remove unused elements in array argument to set_options
- Authentication-results: sourceware.org; auth=none
- References: <F75D4488-5842-4D98-A7CF-CD54017B128F@gmail.com>
- Reply-to: kargl at uw dot edu
On Mon, Dec 19, 2016 at 10:47:09PM +0100, FX wrote:
> For ABI compatibility, we kept some unused elements in the array argument to _gfortran_set_options (options that we have removed). With the current ABI breakage, we might as well remove those.
>
> Bootstrapped and regtested on x86_64-apple-darwin16.3.0
> OK to commit?
>
> FX
>
The patch looks fine to me.
Thinking out loud here. I wonder, however, if we want
to future proof the library against changes to the
options passed by having a few spare unused entried
available. This of course only helps if a new option
needs to be added. It does nothing for removal.
--
Steve