This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR78515
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Sebor <msebor at gmail dot com>, David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Richard Biener <rguenther at suse dot de>, Martin Jambor <mjambor at suse dot cz>, gcc-patches at gcc dot gnu dot org, kugan <kugan dot vivekanandarajah at linaro dot org>
- Date: Thu, 15 Dec 2016 09:23:51 +0100
- Subject: Re: [PATCH] Fix PR78515
- Authentication-results: sourceware.org; auth=none
- References: <alpine.LSU.2.11.1611251157160.5294@t29.fhfr.qr> <20161125131935.ud4wpxebrrjo22yn@virgil.suse.cz> <alpine.LSU.2.11.1611251450310.5294@t29.fhfr.qr> <4c7e80a0-0af7-1be1-f39d-163e9d300c22@gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Dec 14, 2016 at 05:10:23PM -0700, Martin Sebor wrote:
> The regression test is failing on powerpc64le due to the warnings
> below:
>
> FAIL: gcc.dg/torture/pr78515.c -O0 (test for excess errors)
> Excess errors:
> /src/gcc/trunk/gcc/testsuite/gcc.dg/torture/pr78515.c:11:1: warning: GCC
> vector returned by reference: non-standard ABI extension with no
> compatibility guarantee [-Wpsabi]
> /src/gcc/trunk/gcc/testsuite/gcc.dg/torture/pr78515.c:10:1: warning: GCC
> vector passed by reference: non-standard ABI extension with no compatibility
> guarantee [-Wpsabi]
David has fixed this recently, but just for AIX. Generally, -Wno-psabi
is beneficial for all targets if it is needed on just one, I've committed
following:
2016-12-15 Jakub Jelinek <jakub@redhat.com>
* gcc.dg/tree-ssa/forwprop-35.c: Use -Wno-psabi everywhere.
* gcc.dg/torture/pr78515.c: Likewise.
* gcc.dg/pr69634.c: Likewise.
--- gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c.jj 2016-12-14 22:38:37.115389167 +0100
+++ gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c 2016-12-15 09:18:12.158020252 +0100
@@ -1,7 +1,6 @@
/* { dg-do compile } */
-/* { dg-options "-O -fdump-tree-cddce1" } */
+/* { dg-options "-O -fdump-tree-cddce1 -Wno-psabi" } */
/* { dg-additional-options "-msse2" { target { i?86-*-* x86_64-*-* } } } */
-/* { dg-additional-options "-Wno-psabi" { target { powerpc-ibm-aix* } } } */
typedef int v4si __attribute__((vector_size(16)));
typedef float v4sf __attribute__((vector_size(16)));
--- gcc/testsuite/gcc.dg/torture/pr78515.c.jj 2016-12-14 22:38:36.000000000 +0100
+++ gcc/testsuite/gcc.dg/torture/pr78515.c 2016-12-15 09:15:32.000142648 +0100
@@ -1,6 +1,6 @@
/* { dg-do compile } */
+/* { dg-additional-options "-Wno-psabi" } */
/* { dg-additional-options "-mavx512bw" { target x86_64-*-* i?86-*-* } } */
-/* { dg-additional-options "-Wno-psabi" { target powerpc-ibm-aix* } } */
typedef unsigned V __attribute__ ((vector_size (64)));
--- gcc/testsuite/gcc.dg/pr69634.c.jj 2016-12-14 22:38:37.251387392 +0100
+++ gcc/testsuite/gcc.dg/pr69634.c 2016-12-15 09:18:54.812455000 +0100
@@ -1,7 +1,6 @@
/* { dg-do compile } */
-/* { dg-options "-O2 -fno-dce -fschedule-insns -fno-tree-vrp -fcompare-debug" } */
-/* { dg-additional-options "-Wno-psabi -mno-sse" { target i?86-*-* x86_64-*-* } } */
-/* { dg-additional-options "-Wno-psabi" { target powerpc-ibm-aix* } } */
+/* { dg-options "-O2 -fno-dce -fschedule-insns -fno-tree-vrp -fcompare-debug -Wno-psabi" } */
+/* { dg-additional-options "-mno-sse" { target i?86-*-* x86_64-*-* } } */
/* { dg-require-effective-target scheduling } */
typedef unsigned short u16;
Jakub